This project has moved and is read-only. For the latest updates, please go here.

Please make Fail error pages optional

Mar 22, 2012 at 3:44 PM

Vandelay.Fail contains the ErrorPage and the NotFound shapes. Now these are good for testing but if one just wants to keep the built-in error pages they will be still overridden, no matter the feature is enabled or not. So I'd like rather someting optional.

Mar 23, 2012 at 9:54 PM

I don't think there is any way I can do that. Why don't you just override them in your theme?

Mar 23, 2012 at 10:43 PM

Yes, that's an option, but that would mean copying the default templates to reverse the overriding.

To be honest I don't understand why the module includes overrides for these templates. Wouldn't it be just enough to return a HttpNotFoundResult for the 404 tester? I also don't know what's the difference between the Index and Error methods. They both cause an internal server error.

Mar 23, 2012 at 11:21 PM

Now yes, you're right. Please file a bug.

Mar 24, 2012 at 9:27 PM

I've opened one here. Thanks!

Nov 23, 2012 at 11:27 AM

Would you mind fixing this? This is something very inconvenient.

Nov 26, 2012 at 10:07 PM

Can you make a pull request?

Dec 5, 2012 at 5:15 PM

Will you evaluate it? :-)

Dec 5, 2012 at 6:55 PM

Sure.

Dec 8, 2012 at 8:05 PM

Here you go.

Dec 8, 2012 at 11:05 PM

Great, but that's a fork, not a pull request.

Dec 9, 2012 at 6:21 PM

Now you have one.